Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(migrate): fixed duckdb syntax issue #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cnlangzi merged 1 commit into from
Apr 23, 2025
Merged

fix(migrate): fixed duckdb syntax issue #50

cnlangzi merged 1 commit into from
Apr 23, 2025

Conversation

@cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Apr 23, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Bug Fixes:

  • Fixed SQL syntax for DuckDB by removing backticks from table and column names in migration-related SQL queries

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 23, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes a syntax issue with DuckDB by removing backticks around column names in table creation statements and SQL queries. This change ensures compatibility with DuckDB's SQL syntax.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the table creation SQL statements to remove backticks around column names.
  • Removed backticks from column names in the sqle_migrations table creation statement.
  • Removed backticks from column names in the sqle_rotations table creation statement.
 migrate/migrator.go
Modified SQL queries to remove backticks around column and table names.
  • Removed backticks from the checksum column and sqle_migrations table in the isMigrated function's query.
  • Removed backticks from the checksum and rotated_name columns and sqle_rotations table in the rotation query.
 migrate/migrator.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cnlangzi cnlangzi requested a review from Copilot April 23, 2025 12:36
Copilot AI reviewed Apr 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses a DuckDB SQL syntax issue by removing backticks from table and column names in migration-related SQL queries.

  • Removed backticks in CREATE TABLE statements for sqle_migrations and sqle_rotations.
  • Updated SQL query strings in isMigrated and startRotate functions to use unquoted identifiers.

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 23, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using constants for column names to avoid duplication and potential typos.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.71%. Comparing base (fe93ae7) to head (1dc9030).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   75.71%   75.71%           
=======================================
  Files          46       46           
  Lines        2368     2368           
=======================================
  Hits         1793     1793           
  Misses        456      456           
  Partials      119      119
Flag Coverage Δ
Unit-Tests 75.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deepsource-io
Copy link

deepsource-io bot commented Apr 23, 2025

Here's the code health analysis summary for commits fe93ae7..1dc9030. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi merged commit f2035b4 into main Apr 23, 2025
5 checks passed
@cnlangzi cnlangzi deleted the feat/duckdb branch April 23, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cnlangzi