Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix type equivalence for KSP2 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bacecek merged 1 commit into from
Apr 16, 2025
Merged

Fix type equivalence for KSP2 #186

bacecek merged 1 commit into from
Apr 16, 2025

Conversation

@Jeffset
Copy link
Collaborator

@Jeffset Jeffset commented Apr 15, 2025

Fixes #184

@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (d704590) to head (034ac86).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../kotlin/com/yandex/yatagan/lang/ksp/KspTypeImpl.kt 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #186   +/-   ##
=========================================
  Coverage     83.92%   83.93%           
- Complexity     1617     1619    +2     
=========================================
  Files           198      198           
  Lines          8428     8445   +17     
  Branches       1470     1475    +5     
=========================================
+ Hits           7073     7088   +15     
  Misses          825      825           
- Partials        530      532    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jeffset Jeffset marked this pull request as ready for review April 15, 2025 22:05
@Jeffset
Copy link
Collaborator Author

Jeffset commented Apr 15, 2025

@bacecek PTAL

@bacecek bacecek self-requested a review April 16, 2025 07:15
bacecek
bacecek approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@bacecek bacecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix

@bacecek bacecek merged commit 3f1b96d into yandex:main Apr 16, 2025
4 checks passed
@Jeffset Jeffset deleted the fix-184 branch April 16, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bacecek bacecek bacecek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[KSP2] HeavyTest failures because of wildcards

2 participants

@Jeffset @bacecek