Make nodes with changed major allele set available to larch through the callback #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this call back is not at the end of the iteration, is for each individual move (not even filtered by profitability). Following issue #252. |
|
Oh, sorry for the confusion! Perhaps we also need the one I described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only includes nodes on the path from source to destination, excluding source and destination, because during the search phase we assume all moves will split the branch between the destination and the parent of the destination node, creating a new node. I am not sure how to pass this information to larch. (If it creates a zero-length branch, it will be cleaned up at the very end.)
Maybe wait until the larch team confirms it is useful to merge this?