Analyze arm32 neon_x8_t port to arm64 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: czaplejewicz <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects pointer increments in ARM64 FFT assembly to fix a critical bug.
The original ARM64 port incorrectly applied post-increment addressing to intermediate
st1operations, which should have been non-incrementing. This caused data to be written to and read from incorrect memory locations in subsequent loop iterations, leading to corrupted FFT results. This PR reverts those specificst1instructions to non-incrementing forms, matching the ARM32 behavior, and also optimizes the loop counter initialization.