feat: add enforceTemplatedAttrValue option on quotes #387
+109
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new enforceTemplatedAttrValue option to the quotes rule, allowing users to enforce quote styles on templated attribute values.
- Added support for the
enforceTemplatedAttrValueboolean option in the rule schema and implementation - Extended tests with valid and invalid cases for templated attribute values
- Updated documentation to explain and illustrate the new option
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/eslint-plugin/tests/rules/quotes.test.js | Added valid/invalid tests covering the new enforceTemplatedAttrValue behavior |
| packages/eslint-plugin/lib/rules/quotes.js | Introduced the enforceTemplatedAttrValue option and adjusted logic to respect it |
| docs/rules/quotes.md | Updated the rule description, option list, and examples to document the new option |
Comments suppressed due to low confidence (2)
docs/rules/quotes.md:37
- There isn't a matching
<!-- prettier-ignore -->for this<!-- prettier-ignore-end -->. Please remove it or add the corresponding start marker.
<!-- prettier-ignore-end -->
packages/eslint-plugin/lib/rules/quotes.js:6
- [nitpick] The name
SingleOrQuoteOptionis a bit ambiguous. Consider renaming toQuoteStyleOptionorSingleOrDoubleQuoteOptionto make it clearer that it covers both quote styles.
* @typedef {"single" | "double"} SingleOrQuoteOption
Comment on lines
+72
to
+75
| const enforceTemplatedAttrValue = | ||
| context.options && | ||
| context.options[1] && | ||
| context.options[1].enforceTemplatedAttrValue; |
There was a problem hiding this comment.
[nitpick] You could simplify this by destructuring with a default value, e.g.: const { enforceTemplatedAttrValue = false } = context.options[1] || {}; to make the intention clearer and reduce repetitive context.options checks.
Suggested change
| const enforceTemplatedAttrValue = | |
| context.options && | |
| context.options[1] && | |
| context.options[1].enforceTemplatedAttrValue; | |
| const { enforceTemplatedAttrValue = false } = context.options[1] || {}; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 81 81
Lines 2630 2635 +5
Branches 720 725 +5
=======================================
+ Hits 2587 2592 +5
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description