Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: disallow extra properties in rule options #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix: disallow extra properties in rule options #389

merged 1 commit into from
Jul 14, 2025

Conversation

@andreww2012
Copy link
Contributor

Checklist

Description

This PR simply disallows extra properties in rules' schemas which currently allow them.

@yeonjuan yeonjuan requested review from Copilot and yeonjuan and removed request for Copilot July 14, 2025 15:16
yeonjuan
yeonjuan approved these changes Jul 14, 2025
View reviewed changes
Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yeonjuan yeonjuan merged commit e458a3b into yeonjuan:main Jul 14, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (fa96551) to head (c64feb8).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          81       81           
  Lines        2630     2630           
  Branches      720      720           
=======================================
  Hits         2587     2587           
  Misses         43       43
Flag Coverage Δ
unittest 98.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/rules/attrs-newline.js 97.36% <ø> (ø)
...ackages/eslint-plugin/lib/rules/element-newline.js 98.09% <ø> (ø)
packages/eslint-plugin/lib/rules/indent/indent.js 99.43% <ø> (ø)
.../eslint-plugin/lib/rules/no-extra-spacing-attrs.js 98.97% <ø> (ø)
...lint-plugin/lib/rules/no-restricted-attr-values.js 97.56% <ø> (ø)
...ges/eslint-plugin/lib/rules/no-restricted-attrs.js 97.67% <ø> (ø)
...ackages/eslint-plugin/lib/rules/require-img-alt.js 100.00% <ø> (ø)
packages/eslint-plugin/lib/rules/sort-attrs.js 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] schemas of some rules allow extra properties

2 participants

@andreww2012 @yeonjuan