Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yeonjuan
Copy link
Owner

@yeonjuan yeonjuan requested a review from Copilot August 26, 2025 13:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a deprecated "flat/recommended" configuration to the ESLint plugin to support the flat config format while addressing issue #415.

  • Adds a new "flat/recommended" configuration with proper plugin and parser setup
  • Imports the @html-eslint/parser module to support the flat config
  • Marks the new configuration as deprecated to discourage its use

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

rules: recommendedLegacyRules,
},
/**
* @deprecated
Copy link

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @deprecated JSDoc tag should include a reason for deprecation and guidance on what to use instead. Consider adding a description like '@deprecated Use the recommended configuration with flat config format instead.'

Suggested change
* @deprecated
* @deprecated Use the recommended configuration with flat config format instead.

Copilot uses AI. Check for mistakes.
@yeonjuan yeonjuan merged commit 64bc2f9 into main Aug 26, 2025
3 checks passed
@yeonjuan yeonjuan deleted the revert-flat-recommended branch August 26, 2025 13:41
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.54%. Comparing base (01f54b3) to head (855be3b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eslint-plugin/lib/index.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   98.61%   98.54%   -0.08%     
==========================================
  Files          83       83              
  Lines        2748     2751       +3     
  Branches      768      768              
==========================================
+ Hits         2710     2711       +1     
- Misses         38       40       +2     
Flag Coverage Δ
unittest 98.54% <33.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/index.js 80.00% <33.33%> (-20.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] plugin/parser 0.46.0 results in TypeError: Cannot read properties of undefined (reading 'rules')

2 participants