Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type compatibility issues with ESLint by upgrading from version 9.19.0/9.27.0 to 9.39.1 and updating related ESLint ecosystem packages. The changes address type checking errors by adjusting JSDoc annotations and adding type suppressions where needed.
- ESLint upgraded to v9.39.1 across all packages
- Updated
@eslint/corefrom v0.14.0 to v1.0.0 in eslint-plugin - Changed JSDoc annotation from
@satisfiesto@typefor plugin export - Added
@ts-ignorecomments in tests to suppress type errors
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates ESLint and related packages (@eslint/core, @eslint/config-array, @eslint/js, etc.) to newer versions compatible with ESLint 9.39.1 |
| packages/eslint-plugin/lib/index.js | Changed JSDoc annotation from @satisfies to @type for the plugin export |
| packages/eslint-plugin/tests/plugin/export.test.js | Added @ts-ignore comments to suppress type checking errors on plugin.meta property access |
| packages/eslint-plugin/package.json | Updated @eslint/core to ^1.0.0 and eslint to ^9.39.1 |
| packages/cli/package.json | Updated eslint to ^9.39.1 |
| packages/template-parser/package.json | Updated eslint to ^9.39.1 |
| packages/template-syntax-parser/package.json | Updated eslint to ^9.39.1 |
| packages/types/package.json | Updated eslint to ^9.39.1 |
| packages/website/package.json | Updated eslint to ^9.39.1 |
| package.json | Updated eslint to ^9.39.1 in root package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 98.76% 98.69% -0.07%
==========================================
Files 84 85 +1
Lines 2761 2769 +8
Branches 759 759
==========================================
+ Hits 2727 2733 +6
- Misses 34 36 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description