Bug fix to make paths relative to PWD in MacOS app #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This script was made in a hassle really and I wasn't too proud of what I've made into it to start with. The whole point was to allow people to be able to easily modify it as the bash script was too long and harder to fix. This patch proved the point right. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
os.path.abspathusesos.getcwdto convert paths to absolute paths. This is not what we want for the MacOS wrapper script because, when this is called, the current working directory has already been changed. ThePWDenvironment variable should be used instead, which contains the user's current working directory at the time she invoked the application.I also took the liberty to clean up the script a little bit...