Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@gonzotek
Copy link
Contributor

Tell hacs to use readme.md instead of using info.md, which is outdated. Fixes #24

Instead of using info.md, which is outdated.
@gonzotek gonzotek mentioned this pull request Sep 26, 2022
@firstof9
Copy link
Contributor

I'd also remove the info.md in this PR too

@gonzotek gonzotek marked this pull request as draft September 26, 2022 22:28
@gonzotek gonzotek marked this pull request as ready for review September 26, 2022 22:30
@gonzotek
Copy link
Contributor Author

I'd also remove the info.md in this PR too

Thanks for the tip! Looking at the hacs developer site, think there's some more that can be changed/improved in hacs.json, but I need more time to read up on it first.

@zacs zacs merged commit bd33d29 into zacs:master Sep 27, 2022
@gonzotek
Copy link
Contributor Author

Hmm...something's wrong. I checked the info popup in hacs this morning and the readme wasn't showing. If I remove the @zacs fork and add mine, I do get the expected info from the readme.md. Swapping back to the zacs fork and it's gone again. One difference I see is my fork has no releases...since the zacs fork has used releases previously, could hacs need a new release before it'll pick up the change to hacs.json? Sorry for any extra work @zacs, I know you're busy and was trying to keep any maintenance work easy on you.

BTW, on a slightly related note.. I was thinking of looking into what it would take to have hacs pick up the integration in its default repositories (vs requiring the user to add as a custom repository), if that's something you'd want?

@zacs
Copy link
Owner

zacs commented Sep 27, 2022

Yah the release issue is be design -- basically I think HACS defaults to latest release if there are any. I was just planning to not cut a release for something this small (and include it in a later release).

As far as general addition to HACS I would love that. I think it would just be a one liner to the HACS integration list?

@gonzotek
Copy link
Contributor Author

No worries, I was hoping it wasn't something I'd done wrong (again) and just a matter of the releases. Whenever you feel it's worth it!

As far as adding to HACS, I'm going by these two links(in particular, the second one includes some details about an integration manifest, some github actions, and some organizational requirements that all might need to be addressed):
https://hacs.xyz/docs/publish/start
https://hacs.xyz/docs/publish/include

I'll work through the requirements via my fork then submit PRs and/or issues for everything when I think I have a good enough handle on it all. Might be a couple weeks or a bit more.

vasqued2 referenced this pull request in vasqued2/ha-teamtracker Oct 11, 2022
commit edd0ff8
Merge: bf46ecd 509badc
Author: Zac <[email protected]>
Date:   Sun Oct 2 10:25:08 2022 -0700

    Merge pull request #28 from gonzotek/master

commit 509badc
Author: gonzotek <[email protected]>
Date:   Sun Oct 2 11:17:04 2022 -0400

    iot_class is also not used by hacs.json

commit de14c79
Author: gonzotek <[email protected]>
Date:   Sun Oct 2 11:13:10 2022 -0400

    domains key isn't allowed in hacs.json

    Per https://hacs.xyz/docs/publish/start/#hacsjson

commit f9031de
Author: gonzotek <[email protected]>
Date:   Sun Oct 2 11:08:47 2022 -0400

    Create hacs.yaml

    Preparing for HACS default repository submission

commit e04e46c
Author: gonzotek <[email protected]>
Date:   Sun Oct 2 08:54:38 2022 -0400

    remove title since it's a brand

    ¯\_(ツ)_/¯

commit 39f9b45
Author: gonzotek <[email protected]>
Date:   Sun Oct 2 08:15:35 2022 -0400

    Update __init__.py

    wrap values["location"] in try/except to catch games with no State info (e.g. the 10/2/2022 MIN @ NO London game)

commit bf46ecd
Merge: bd33d29 6bf1beb
Author: Zac <[email protected]>
Date:   Wed Sep 28 18:06:26 2022 -0700

    Merge pull request #26 from firstof9/convert-team-colors

    feat: add team colors as RGB color lists

commit 6bf1beb
Author: Chris <[email protected]>
Date:   Wed Sep 28 11:32:50 2022 -0700

    add rgb changes as new attribute

commit 83596dd
Author: Chris <[email protected]>
Date:   Tue Sep 27 16:29:42 2022 -0700

    fix reconfigure flow

commit d4dd621
Author: Chris <[email protected]>
Date:   Tue Sep 27 16:01:17 2022 -0700

    update coordinator class name

commit b074890
Author: Chris <[email protected]>
Date:   Tue Sep 27 15:59:42 2022 -0700

    formatting

commit 805634a
Author: Chris <[email protected]>
Date:   Tue Sep 27 15:14:30 2022 -0700

    fix colors being none

commit 4086a21
Author: Chris <[email protected]>
Date:   Tue Sep 27 14:58:55 2022 -0700

    colors is a list

commit 6f0802c
Author: Chris <[email protected]>
Date:   Tue Sep 27 13:02:11 2022 -0700

    linting

commit a123046
Author: Chris <[email protected]>
Date:   Tue Sep 27 13:00:57 2022 -0700

    feat: convert team colors to RGB color lists

commit bd33d29
Merge: b989ff3 a96ec05
Author: Zac <[email protected]>
Date:   Mon Sep 26 17:02:02 2022 -0700

    Merge pull request #25 from gonzotek/master

commit a96ec05
Author: gonzotek <[email protected]>
Date:   Mon Sep 26 18:29:45 2022 -0400

    Delete info.md

commit a43e07f
Author: gonzotek <[email protected]>
Date:   Mon Sep 26 13:26:28 2022 -0400

    Update hacs.json to render the repository readme

    Instead of using info.md, which is outdated.

commit b989ff3
Author: Zac <[email protected]>
Date:   Thu Sep 8 14:13:30 2022 -0700

    Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong text

3 participants