London game fix (Location missing State info) and hacs default repo prep work #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrap values["location"] in try/except to catch games with no State info (e.g. the 10/2/2022 MIN @ NO London game)
Codecov ReportBase: 63.77% // Head: 63.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 2 2
Lines 196 196
=======================================
Hits 125 125
Misses 71 71 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
Yeah...so I'm not sure what to do with the hassfst fail...it's indicating a translation problem, but afaik, my two-liner fix didn't touch anything translation-related. |
Closed
¯\_(ツ)_/¯
Preparing for HACS default repository submission
Contributor
Author
|
Resolved the hassfest fail: since 'NFL' is a brand, the integration title doesn't need to be translated. Then went ahead and added the hacs github action and resolved its fails. This should put the integration on track (or nearly so) for placing into the HACS default repositories. |
vasqued2
referenced
this pull request
in vasqued2/ha-teamtracker
Oct 11, 2022
commit edd0ff8 Merge: bf46ecd 509badc Author: Zac <[email protected]> Date: Sun Oct 2 10:25:08 2022 -0700 Merge pull request #28 from gonzotek/master commit 509badc Author: gonzotek <[email protected]> Date: Sun Oct 2 11:17:04 2022 -0400 iot_class is also not used by hacs.json commit de14c79 Author: gonzotek <[email protected]> Date: Sun Oct 2 11:13:10 2022 -0400 domains key isn't allowed in hacs.json Per https://hacs.xyz/docs/publish/start/#hacsjson commit f9031de Author: gonzotek <[email protected]> Date: Sun Oct 2 11:08:47 2022 -0400 Create hacs.yaml Preparing for HACS default repository submission commit e04e46c Author: gonzotek <[email protected]> Date: Sun Oct 2 08:54:38 2022 -0400 remove title since it's a brand ¯\_(ツ)_/¯ commit 39f9b45 Author: gonzotek <[email protected]> Date: Sun Oct 2 08:15:35 2022 -0400 Update __init__.py wrap values["location"] in try/except to catch games with no State info (e.g. the 10/2/2022 MIN @ NO London game) commit bf46ecd Merge: bd33d29 6bf1beb Author: Zac <[email protected]> Date: Wed Sep 28 18:06:26 2022 -0700 Merge pull request #26 from firstof9/convert-team-colors feat: add team colors as RGB color lists commit 6bf1beb Author: Chris <[email protected]> Date: Wed Sep 28 11:32:50 2022 -0700 add rgb changes as new attribute commit 83596dd Author: Chris <[email protected]> Date: Tue Sep 27 16:29:42 2022 -0700 fix reconfigure flow commit d4dd621 Author: Chris <[email protected]> Date: Tue Sep 27 16:01:17 2022 -0700 update coordinator class name commit b074890 Author: Chris <[email protected]> Date: Tue Sep 27 15:59:42 2022 -0700 formatting commit 805634a Author: Chris <[email protected]> Date: Tue Sep 27 15:14:30 2022 -0700 fix colors being none commit 4086a21 Author: Chris <[email protected]> Date: Tue Sep 27 14:58:55 2022 -0700 colors is a list commit 6f0802c Author: Chris <[email protected]> Date: Tue Sep 27 13:02:11 2022 -0700 linting commit a123046 Author: Chris <[email protected]> Date: Tue Sep 27 13:00:57 2022 -0700 feat: convert team colors to RGB color lists commit bd33d29 Merge: b989ff3 a96ec05 Author: Zac <[email protected]> Date: Mon Sep 26 17:02:02 2022 -0700 Merge pull request #25 from gonzotek/master commit a96ec05 Author: gonzotek <[email protected]> Date: Mon Sep 26 18:29:45 2022 -0400 Delete info.md commit a43e07f Author: gonzotek <[email protected]> Date: Mon Sep 26 13:26:28 2022 -0400 Update hacs.json to render the repository readme Instead of using info.md, which is outdated. commit b989ff3 Author: Zac <[email protected]> Date: Thu Sep 8 14:13:30 2022 -0700 Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap values["location"] in try/except to catch games with no State info (e.g. the 10/2/2022 MIN @ NO London game)