-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(coprocessor): add a non-blocking, distributed locking mechanism in tfhe-worker #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
goshawk-3
wants to merge
32
commits into
release/0.10.x
Choose a base branch
from
feature/tfhe-worker/scalability
base: release/0.10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CI InsightsHere's what we observed from your CI run for 1df24ba. 🟢 All jobs passed!But CI Insights is watching 👀 |
Contributor
|
values.yaml new parameters are missing |
fe5a63f to
dd53922
Compare
b08dd5d to
a3453db
Compare
Contributor
Author
|
See also: #1506 (comment) |
687e931 to
e63b299
Compare
Collaborator
Please could you update the charts with these (or any new params added) - I think we've mostly converged on the arch, so would be good to start planning for deployment. |
b642f1b to
c35b36c
Compare
…iple workers It provides a non-blocking, distributed locking mechanism that coordinates dependence-chain processing across multiple tfhe-workers. A worker can acquire ownership of the next available dependence-chain entry for processing ordered by last_updated_at (FIFO queue-like approach). Ownership expires after a timeout, enabling work-stealing by other workers. New CLI param --worker_id
- Added LockingReason for logging - Make expiry configurable
- add --dcid_ttl_sec config - add otel traces for dcid
37097ca to
eabc5bc
Compare
eabc5bc to
bf270bc
Compare
…leted computations
bf270bc to
e305ddf
Compare
46dcec4 to
4402c9e
Compare
…ertext_digest tables
rudy-6-4
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a non-blocking, distributed locking mechanism that coordinates dependence-chain processing across multiple tfhe-workers replicas.
A worker can acquire a lock of the next available dependence-chain entry for processing ordered by last_updated_at (FIFO queue-like approach).
A permission to acquire a DCID depends on either
dependency_count is 0 and DCID is not locked
or
dependency_count is 0 and DCID is locked but the lock has expired
Ownership expires after a timeout, enabling work-stealing by other workers for resilience.
GC procedure is regularly executed to clean up processed DCIDs