docs(coprocessor): fix incorrect content in KMSVerifier section of contracts.md #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CI InsightsHere's what we observed from your CI run for 08caed3. 🟢 All jobs passed!But CI Insights is watching 👀 |
abffb70 to
abee8e4
Compare
Contributor
Author
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 8ee9f43 |
Merge Queue Status✅ The pull request has been merged at 08caed3 This pull request spent 13 minutes 2 seconds in the queue, including 11 minutes 7 seconds running CI. Required conditions to merge
|
0xalexbel
approved these changes
Dec 22, 2025
Remove misplaced paragraph about input ciphertext verification from KMSVerifier section. That content incorrectly described InputVerifier functionality and referenced a non-existent function. Update InputVerifier section with accurate description of the input verification flow using coprocessor signers. Fixes zama-ai/fhevm-internal#797
abee8e4 to
08caed3
Compare
antoniupop
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
The KMSVerifier section in
coprocessor/docs/fundamentals/fhevm/contracts.mdcontained a paragraph that incorrectly described InputVerifier functionality:This was incorrect because:
verifyInputEIP712KMSSignaturesreferenced in the docs doesn't exist in KMSVerifierActual responsibilities:
verifyDecryptionEIP712KMSSignatureswith KMS signer signaturesverifyInputwith coprocessor signer signaturesIdentified during PR review: #1597 (comment)
Test plan
Closes zama-ai/fhevm-internal#797