Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(protocol-contracts): add ConfidentialTokensRegistry contract #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melanciani merged 8 commits into from
Dec 22, 2025
Merged

feat(protocol-contracts): add ConfidentialTokensRegistry contract #1610

melanciani merged 8 commits into from
Dec 22, 2025

Conversation

@melanciani
Copy link
Contributor

@melanciani melanciani commented Dec 18, 2025 •
edited
Loading

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2025
@mergify
Copy link

mergify bot commented Dec 18, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 61016d4.

🟢 All jobs passed!

But CI Insights is watching 👀

@melanciani melanciani force-pushed the melanciani/792/protocol-contracts/add_confidential_tokens_registry branch from 9fd6946 to 2dc2cdb Compare December 19, 2025 10:33
@melanciani melanciani marked this pull request as ready for review December 19, 2025 10:36
@melanciani melanciani requested a review from a team as a code owner December 19, 2025 10:36
@melanciani melanciani requested a review from jatZama December 19, 2025 10:37
@melanciani melanciani requested a review from a team as a code owner December 19, 2025 16:30
@melanciani melanciani requested a review from jatZama December 19, 2025 16:30
jatZama
jatZama reviewed Dec 19, 2025
View reviewed changes
jatZama
jatZama reviewed Dec 19, 2025
View reviewed changes
@jatZama
Copy link
Member

jatZama commented Dec 19, 2025 •
edited
Loading

I put few comments, but globally the PR looks very good. One of the suggestions I put was to add some mention of wrapper somewhere in the natspecs, for the sake of clarity.
The other main suggestion, was to add a check on supportsInterface on the confidential token, since EIP165 is a requirement to EIP7984, I think we should leverage it here.

@melanciani melanciani requested a review from jatZama December 22, 2025 11:31
@melanciani melanciani force-pushed the melanciani/792/protocol-contracts/add_confidential_tokens_registry branch from c72bb40 to 70d51d3 Compare December 22, 2025 13:39
@melanciani melanciani merged commit f2bcf81 into main Dec 22, 2025
70 checks passed
@melanciani melanciani deleted the melanciani/792/protocol-contracts/add_confidential_tokens_registry branch December 22, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jatZama jatZama jatZama approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melanciani @jatZama