BaseZapPlugin and KeyValueGetter #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y: new methods added to Vectors; ported Direction from arena-api
Stuff to support latest update on Arena-Api
VegetalDev
reviewed
Sep 24, 2021
VegetalDev
reviewed
Sep 24, 2021
VegetalDev
reviewed
Sep 24, 2021
src/main/java/io/github/zap/commons/keyvaluegetters/AbstractKeyValueGetter.java
Outdated
Show resolved
Hide resolved
VegetalDev
reviewed
Sep 24, 2021
src/main/java/io/github/zap/commons/keyvaluegetters/AbstractKeyValueGetter.java
Outdated
Show resolved
Hide resolved
VegetalDev
reviewed
Sep 24, 2021
src/main/java/io/github/zap/commons/keyvaluegetters/AbstractKeyValueGetter.java
Show resolved
Hide resolved
VegetalDev
reviewed
Sep 24, 2021
src/main/java/io/github/zap/commons/keyvaluegetters/ValueDeserializer.java
Outdated
Show resolved
Hide resolved
VegetalDev
reviewed
Sep 24, 2021
| import java.util.Map; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class ReflectionUtilsTest { |
Contributor
There was a problem hiding this comment.
since this is the only test you've written, have you made sure the other non-trivial stuff works?
Member
Author
There was a problem hiding this comment.
No, I made the test solely for the Reflection stuff because it is so damn hard to debug recursion. I will eventually add other tests but for now, my time is kinda run out
Added TimeUtils.measure Add additional timer method in BaseZapPlugin.java Convert var into explicit type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BaseZapPlugin containing some frequently used methods.
Add KeyValueGetter (EnvironmentGetter is one of the implementations)
Move Helper classes from other repos that can be applied anywhere