New events #3
Merged
New events #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y: new methods added to Vectors; ported Direction from arena-api
(with support added for asynchronous events and of course bukkit proxy events), better syntax for mapping events, and a unit test for SimpleEvent. also lots and lots of javadoc
tachibanayui
requested changes
Sep 22, 2021
| static <T extends org.bukkit.event.Event> Event<T> bukkitProxy(@NotNull Plugin plugin, | ||
| @NotNull Class<T> bukkitEventClass) { | ||
| return bukkitProxy(plugin, bukkitEventClass, EventPriority.NORMAL, true); | ||
| return bukkitProxy(plugin, bukkitEventClass, EventPriority.NORMAL, false); |
Member
There was a problem hiding this comment.
Yeah, that should be enough ig, I gonna resolve the conversation
tachibanayui
approved these changes
Sep 22, 2021
Member
tachibanayui
left a comment
There was a problem hiding this comment.
Good and :kindacringeiflikousesit:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.