-
Notifications
You must be signed in to change notification settings - Fork 172
ZIP-321: Payment Request URIs #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ChileBob this may be of interest to you. |
|
@adityapk00 I'd like to draw your attention to this (standardization of zcash payment URIs) as well. |
|
A request, could a few fully formatted URIs be provided as examples? |
pacu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @ChileBob's request on some samples.
daira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some more minor changes to the syntax, and addition of an Examples section.
Replace `-` with `.` for parameter index delimiter and clarify specification of amount and address values. Co-authored-by: Daira Hopwood <[email protected]>
daira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
Co-authored-by: Daira Hopwood <[email protected]>
Co-authored-by: Daira Hopwood <[email protected]>
Co-authored-by: Daira Hopwood <[email protected]>
Co-authored-by: Kris Nuttycombe <[email protected]>
Cosmetics.
…eriod clause. Co-authored-by: Daira Hopwood <[email protected]>
Signed-off-by: Daira Hopwood <[email protected]>
nathan-at-least
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification about zcashaddress grammar.
| .. code-block:: EBNF | ||
| zcashurn = "zcash:" ( zcashaddress [ "?" zcashparams ] / "?" zcashparams ) | ||
| zcashaddress = 1*base58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line mean a zcash address begins with a 1 prefix? If so, that's incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this means that the zcashaddress production is one or more base58 characters. See https://github.com/zcash/zips/pull/395/files#diff-a386636de36a003f2f6c54ee53696106R127. Also you'll note that this production has changed in a later amendment to the ZIP, and some more qualifications on addresses were added in 8c4e0b5#diff-a386636de36a003f2f6c54ee53696106R152
Closes #347