Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Sep 4, 2020

Closes #347

@nuttycom nuttycom self-assigned this Sep 4, 2020
@nuttycom nuttycom requested a review from daira September 4, 2020 16:59
@nuttycom
Copy link
Contributor Author

nuttycom commented Sep 4, 2020

@ChileBob this may be of interest to you.

@nuttycom nuttycom added this to the Core Sprint 2020-35 milestone Sep 4, 2020
@nuttycom
Copy link
Contributor Author

nuttycom commented Sep 4, 2020

@adityapk00 I'd like to draw your attention to this (standardization of zcash payment URIs) as well.

@ChileBob
Copy link

ChileBob commented Sep 5, 2020

A request, could a few fully formatted URIs be provided as examples?

Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @ChileBob's request on some samples.

Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some more minor changes to the syntax, and addition of an Examples section.

nuttycom and others added 2 commits September 15, 2020 11:48
Replace `-` with `.` for parameter index delimiter and clarify specification of amount and address values.

Co-authored-by: Daira Hopwood <[email protected]>
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Co-authored-by: Daira Hopwood <[email protected]>
daira and others added 3 commits September 24, 2020 16:44
Co-authored-by: Kris Nuttycombe <[email protected]>
Cosmetics.
@daira daira merged commit a78a129 into zcash:master Sep 24, 2020
@github-pages github-pages bot temporarily deployed to github-pages September 24, 2020 17:56 Inactive
@nuttycom nuttycom deleted the zip-0321 branch September 24, 2020 18:33
Copy link
Contributor

@nathan-at-least nathan-at-least left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification about zcashaddress grammar.

.. code-block:: EBNF
zcashurn = "zcash:" ( zcashaddress [ "?" zcashparams ] / "?" zcashparams )
zcashaddress = 1*base58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line mean a zcash address begins with a 1 prefix? If so, that's incorrect.

Copy link
Contributor Author

@nuttycom nuttycom Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this means that the zcashaddress production is one or more base58 characters. See https://github.com/zcash/zips/pull/395/files#diff-a386636de36a003f2f6c54ee53696106R127. Also you'll note that this production has changed in a later amendment to the ZIP, and some more qualifications on addresses were added in 8c4e0b5#diff-a386636de36a003f2f6c54ee53696106R152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ZIP 321] Specify payment request URIs

6 participants