Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@YunataSavior
Copy link
Contributor

In addition, please review what I've done for mpHIO in npc_jagar and obj_pumpkin. This is how we must work with l_HIO in these files moving forward, as that means of writing is how we can cleanly match both release and debug.

Closes #831

@decomp-dev
Copy link

decomp-dev bot commented Sep 30, 2025

Report for ShieldD (40e61bf - d9af1b6)

📈 Matched code: 20.45% (+0.05%, +8036 bytes)

✅ 43 new matches
Unit Function Bytes Before After
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_HIO_c::genMessage(JORMContext*) +1360 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_HIO_c::listenPropertyEvent(const JORPropertyEvent*) +788 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::create() +756 0.53% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Draw() +421 0.94% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daNpc_Jagar_c::crashPumpkin(fopAc_ac_c*) +300 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::crash() +296 1.33% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setWaterPrtcl() +285 1.39% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::~daObj_Pumpkin_c() +277 24.93% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setMtx() +261 1.52% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin __sinit_\d_a_obj_pumpkin_cpp +232 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::popup(float, float, cXyz*) +216 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::calcRollAngle(short, int) +160 2.44% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::CreateHeap() +156 2.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::daObj_Pumpkin_c() +152 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::isDelete() +141 2.78% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getType() +136 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_HIOParam::operator=(const daObj_Pumpkin_HIOParam&) +124 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::reset() +120 3.23% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Delete() +96 4.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setSmokePrtcl() +96 4.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setHamonPrtcl() +93 4.17% 100.00%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_HIO_c::~daNpc_Jagar_HIO_c() +92 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_HIO_c::~daObj_Pumpkin_HIO_c() +92 0.00% 100.00%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_HIOParam::operator=(const daNpc_Jagar_HIOParam&) +88 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setRoomNo() +85 4.55% 100.00%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_HIO_c::daNpc_Jagar_HIO_c() +80 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_HIO_c::daObj_Pumpkin_HIO_c() +80 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getProcType() +80 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getItemTableNo() +76 0.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setEnvTevColor() +76 5.00% 100.00%

...and 13 more new matches

📈 12 improvements in unmatched functions
Unit Function Bytes Before After
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Execute() +5217 0.08% 98.75%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_HIO_c::genMessage(JORMContext*) +546 0.00% 99.69%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getWallAngle(short, short*) +420 0.94% 99.95%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::setParam() +120 74.89% 96.29%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::setAttnPos() +28 92.26% 95.82%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::wait(void*) +26 91.22% 92.28%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::chkFindWolf() +26 64.63% 88.48%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin fopAcM_OffCarryType(fopAc_ac_c*, fopAcM_CARRY) +17 0.00% 72.50%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_HIO_c::listenPropertyEvent(const JORPropertyEvent*) +3 0.00% 0.87%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::cutFindWolf(int) +3 96.95% 97.26%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::talkwithBou(void*) +3 33.18% 33.53%
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::setCollision() +1 98.27% 98.32%
📉 1 regression in unmatched functions
Unit Function Bytes Before After
d_a_npc_jagar/d/actor/d_a_npc_jagar daNpc_Jagar_c::create() -3 80.45% 80.20%

Report for GZ2E01 (40e61bf - d9af1b6)

📈 Matched code: 89.09% (+0.10%, +11208 bytes)
📈 Linked code: 63.35% (+0.10%, +11216 bytes)

✅ 35 new matches
Unit Function Bytes Before After
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Execute() +5608 0.07% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::create() +876 0.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::crash() +685 0.58% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::~daObj_Pumpkin_c() +548 13.29% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Draw() +416 0.95% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getWallAngle(short, short*) +396 1.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setMtx() +261 1.52% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setWaterPrtcl() +252 1.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::calcRollAngle(short, int) +156 2.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::CreateHeap() +141 2.78% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::isDelete() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setSmokePrtcl() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::reset() +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin __sinit_d_a_obj_pumpkin_cpp +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setEnvTevColor() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setHamonPrtcl() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGLin::~cM3dGLin() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGCyl::~cM3dGCyl() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGAab::~cM3dGAab() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGPla::~cM3dGPla() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cCcD_GStts::~cCcD_GStts() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setRoomNo() +65 5.88% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Delete() +49 7.69% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::createHeapCallBack(fopAc_ac_c*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Create(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Delete(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Execute(void*) +28 12.50% 100.00%

...and 5 more new matches


Report for GZ2P01 (40e61bf - d9af1b6)

📈 Matched code: 88.75% (+0.10%, +11208 bytes)

✅ 35 new matches
Unit Function Bytes Before After
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Execute() +5608 0.07% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::create() +876 0.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::crash() +685 0.58% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::~daObj_Pumpkin_c() +548 13.29% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Draw() +416 0.95% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getWallAngle(short, short*) +396 1.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setMtx() +261 1.52% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setWaterPrtcl() +252 1.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::calcRollAngle(short, int) +156 2.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::CreateHeap() +141 2.78% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::isDelete() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setSmokePrtcl() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::reset() +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin __sinit_d_a_obj_pumpkin_cpp +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setEnvTevColor() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setHamonPrtcl() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGLin::~cM3dGLin() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGCyl::~cM3dGCyl() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGAab::~cM3dGAab() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGPla::~cM3dGPla() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cCcD_GStts::~cCcD_GStts() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setRoomNo() +65 5.88% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Delete() +49 7.69% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::createHeapCallBack(fopAc_ac_c*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Create(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Delete(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Execute(void*) +28 12.50% 100.00%

...and 5 more new matches


Report for GZ2J01 (40e61bf - d9af1b6)

📈 Matched code: 88.21% (+0.10%, +11208 bytes)

✅ 35 new matches
Unit Function Bytes Before After
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Execute() +5608 0.07% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::create() +876 0.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::crash() +685 0.58% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::~daObj_Pumpkin_c() +548 13.29% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Draw() +416 0.95% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::getWallAngle(short, short*) +396 1.00% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setMtx() +261 1.52% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setWaterPrtcl() +252 1.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::calcRollAngle(short, int) +156 2.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::CreateHeap() +141 2.78% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::isDelete() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setSmokePrtcl() +129 3.03% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::reset() +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin __sinit_d_a_obj_pumpkin_cpp +113 3.45% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setEnvTevColor() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setHamonPrtcl() +89 4.35% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGLin::~cM3dGLin() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGCyl::~cM3dGCyl() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGAab::~cM3dGAab() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cM3dGPla::~cM3dGPla() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin cCcD_GStts::~cCcD_GStts() +69 5.56% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::setRoomNo() +65 5.88% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::Delete() +49 7.69% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_c::createHeapCallBack(fopAc_ac_c*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Create(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Delete(void*) +28 12.50% 100.00%
d_a_obj_pumpkin/d/actor/d_a_obj_pumpkin daObj_Pumpkin_Execute(void*) +28 12.50% 100.00%

...and 5 more new matches

@Pheenoh Pheenoh merged commit c7703d1 into zeldaret:main Sep 30, 2025
4 checks passed
@YunataSavior YunataSavior deleted the obj_pumpkin branch October 4, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

d_a_obj_pumpkin.cpp

3 participants