Refactor ZenbaseTracer add_trace logic and make LMDemo hashing safer for nested structures #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer for nested structures
|
Hey @ammirsm -- can't help but notice you're active around here. Would you mind taking a look? Thanks in advance! (I think the CI failure is unrelated) |
Hey @b8zhong Thanks for the contribution. |
|
Friendly bump! I know how busy life gets... |
|
Those errors in CI are fine, they are for integrations that we are blocked by langfuse. Thanks for the contribution. |
|
Awesome -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ZenbaseTracer.add_traceto usesetdefault()and remove redundantmove_to_endcallsLMDemo.__hash__to handle nested dicts/lists/setsWhy?
LMDemohashable without errors for common nested structuresNon-breaking