#322: implement Fbe.over? for check github quota, lifetime, and timeout
#326
+121
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used🧬 Code graph analysis (4)lib/fbe/iterate.rb (1)
lib/fbe/over.rb (1)
lib/fbe/conclude.rb (1)
test/fbe/test_over.rb (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
lib/fbe/conclude.rb(2 hunks)lib/fbe/iterate.rb(2 hunks)lib/fbe/over.rb(1 hunks)test/fbe/test_over.rb(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-29T21:46:05.507Z
Learnt from: Yegorov
PR: zerocracy/fbe#319
File: test/fbe/test_iterate.rb:388-389
Timestamp: 2025-09-29T21:46:05.507Z
Learning: In `Fbe.iterate` with `sort_by` configuration in `lib/fbe/iterate.rb`: when the sorted enumerator exhausts (StopIteration), the marker is correctly reset to `since` (typically 0). This reset behavior is intentional and allows the iteration to restart from the beginning on the next run.
Applied to files:
lib/fbe/iterate.rb
🧬 Code graph analysis (4)
lib/fbe/conclude.rb (1)
lib/fbe/over.rb (1)
over?(20-38)
lib/fbe/iterate.rb (1)
lib/fbe/over.rb (1)
over?(20-38)
lib/fbe/over.rb (1)
lib/fbe/octo.rb (2)
octo(44-232)off_quota?(168-177)
test/fbe/test_over.rb (2)
lib/fbe/over.rb (1)
over?(20-38)lib/fbe/octo.rb (1)
octo(44-232)
|
@yegor256 can you take a look, please? |
|
@Yegorov thanks! |
|
@Yegorov Thanks for the contribution! You've earned +12 points for this: +24 as a basis, -4 for exceeding our 133 hits-of-code threshold (162 HoC), and -8 for missing code review which is essential for quality assurance per our policy. Consider breaking larger contributions into smaller, reviewable chunks to maximize your rewards and maintain code quality - this approach will help you earn the full bonus potential. Please keep them coming! Your running balance is +721; don't forget to check your Zerocracy balance too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322
Summary by CodeRabbit