Tweaks for more runtime environments #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary under Windows because Microsoft Antivirus will lock directories while they are scanned. A retry will give the AV some time to run and unlock the directory.
When topgen crashes it leaves a lot of .~ staging files around, which if they exist on a future run causes the script to fail. --clear-cache argument goes through and cleans these up, which saves some effort on debug. This argument is false by default.
qmn
pushed a commit
that referenced
this pull request
May 16, 2025
This fix was added in #26612 but a commit accidently drops the ##1 delay. Signed-off-by: Kinza Qamar <[email protected]>
pqcfox
pushed a commit
that referenced
this pull request
Jul 26, 2025
[sync] Sync upstream changes to earlgrey_1.0.0 branch.
Collaborator
|
Sorry for the delay, just now saw this PR when looking through the PR list. Looks fine to me, but @matutem is more of an authority on the ipgen/topgen tooling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two features
--clear-cachesthat removes all the staging files starting with .~. This is helpful when debugging partially aborted runs.