feat: add option for denser layout of FileList #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickrodz0503
approved these changes
Oct 5, 2024
|
Please merge this! There's way too much space between entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple attempt to address #745 and introduce an option for a bit more dense layout. It is a very simple solution for now with just a quick toggle in the settings for a "more dense layout" which shrinks the height of the list elements to 48 dp.
In grid view, I increased the column count to 3 (instead of 2). More than 3 is not optimal since due to the badges and the overflow button, the width of the TextView gets very small and one might think about changing the item appearance in grid view entirely.
I know that as stated in the PR template, maybe this PR won't get accepted but since this is a quite simple implementation feel free to make the changes yourself since I think this is a long requested feature and many people would benefit from this basic implementation already.
Screenshots: