Do not log warning when passing bytes to listener object #1656
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the log level for a specific warning message in the zigpy listeners module from warning to debug level. The change addresses issue #1655 where warning messages were being logged when devices send unknown ZCL commands that zigpy passes through as raw bytes.
- Changes log level from warning to debug for matcher/command incompatibility messages
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
TheJulianJES
left a comment
There was a problem hiding this comment.
Seems good with the tests fixed
diff --git a/tests/test_listeners.py b/tests/test_listeners.py
index d7d728bc..3a73bdf8 100644
--- a/tests/test_listeners.py
+++ b/tests/test_listeners.py
@@ -157,7 +157,7 @@ async def test_listener_callback_invalid_matcher(caplog):
callback=mock.Mock(),
)
- with caplog.at_level(logging.WARNING):
+ with caplog.at_level(logging.DEBUG):
assert not listener.resolve(make_hdr(off()), off())
assert listener.callback.mock_calls == []
@@ -170,7 +170,7 @@ async def test_listener_callback_invalid_call(caplog):
callback=mock.Mock(),
)
- with caplog.at_level(logging.WARNING):
+ with caplog.at_level(logging.DEBUG):
assert not listener.resolve(make_hdr(on()), b"data")
assert listener.callback.mock_calls == []
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1656 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 57 57
Lines 11638 11638
=======================================
Hits 11556 11556
Misses 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #1655.
For devices that send unknown ZCL commands, zigpy currently passes through the raw bytes instead of parsing the command into a structure. This is behavior that will be removed at some point.