Fix ZCLCommandButtonMetadata.kwargs to factory=frozendict
#1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory=frozendict`
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a dataclass field definition issue where ZCLCommandButtonMetadata.kwargs was incorrectly using default=frozendict instead of factory=frozendict, which would assign the class itself rather than an instance.
- Changed
default=frozendicttofactory=frozendictfor thekwargsfield - Ensures each instance gets a new
frozendict()instance rather than sharing the class object - Aligns with the existing pattern used for
constant_attributesfield
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1685 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 62 62
Lines 12045 12048 +3
=======================================
+ Hits 11962 11965 +3
Misses 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
default=frozendictwould set thefrozendictclass itself forkwargs.However, as we'll only use
ZCLCommandButtonMetadatawhencommand_buttonis called, which defaults tofrozendict()forkwargs, the issue didn't manifest itself.Still, we should fix this, either by doing
default=frozendict()orfactory=frozendict. As this default will never be really used and we already usefactoryforconstant_attributes, I also went with that.With
default=frozendict(), we'd have the same instance for allZCLCommandButtonMetadata. Withfactory, a new one for each. To us, this doesn't really matter, but see the other points I made 😄