Replace pyserial-asyncio with pyserial-asyncio-fast #1696
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the pyserial-asyncio dependency with pyserial-asyncio-fast, removing the fallback logic that previously tried to import the faster library and fell back to the standard one. This change simplifies the codebase by making pyserial-asyncio-fast the only supported serial library.
- Removes conditional import logic and always uses
serial_asyncio_fast - Updates type hints to reference the fast library
- Simplifies dependency declaration in
pyproject.toml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zigpy/serial.py | Replaces conditional import with direct import of serial_asyncio_fast and updates all type annotations |
| pyproject.toml | Consolidates dependency to pyserial-asyncio-fast removing platform-specific conditions |
Comments suppressed due to low confidence (1)
zigpy/serial.py:1
- [nitpick] The docstring refers to 'serial_asyncio_fast' but uses underscores instead of hyphens. The package name is 'pyserial-asyncio-fast' (with hyphens). Consider updating the docstring to match the package name for clarity.
from __future__ import annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1696 +/- ##
=======================================
Coverage 99.30% 99.31%
=======================================
Files 63 63
Lines 12188 12184 -4
=======================================
- Hits 12103 12100 -3
+ Misses 85 84 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
left a comment
There was a problem hiding this comment.
Seems like "Zigbee for Domoticz" already uses pyserial-asyncio-fast for zigpy, so we shouldn't cause any issues there: https://github.com/search?q=owner%3Azigbeefordomoticz%20pyserial-asyncio&type=code
Fixes #1604