Fix TransmitOptions bitmap member
#1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1600 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 58 58
Lines 11460 11460
=======================================
Hits 11396 11396
Misses 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like Copilot could have caught this 😄: #1592 (comment). I've enabled Copilot reviews for all future zigpy PRs as a test, we can disable it if it's too noisy. |
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the bitmap values for the TransmitOptions flags to ensure each flag is a unique power-of-two value instead of overlapping integers.
- Replaced hard-coded integers with bit-shift expressions for each flag
- Ensures
FORCE_ROUTE_DISCOVERYno longer conflicts with the combination of other flags
This was referenced May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FORCE_ROUTE_DISCOVERYbeing set to3was not valid: it became an alias forACK | APS_Encryption, since this is a bitmap, and broke retries for zigpy-znp.Related: home-assistant/core#145561 (comment)