fix(build): remove asm_legacy references for latest Zig
#2526
Conversation
Techatrix
left a comment
There was a problem hiding this comment.
The following two function are now unused and should be removed:
- https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L120C4-L120C23
- https://github.com/neoto/zls/blob/e8e542a2ce47ce73a6562edf586d8f63d65e1e2c/src/ast.zig#L206
The following test should also be removed:
The minimum version now corresponds to this commit
The minimum_zig_version should be an exact version that is provided on ziglang.org. The prebuilt Zig binaries are currently not updating so this PR cannot be merged until then.
I don't use Nix so things related to that probably need to be addressed additionally.
I can take care of that before merging.
I guess I should note that the formatter reordered the imports, but I can revert these changes if necessary...
Yes, that should be reverted.
|
Thank you for the review!
Done
I've reverted that change because the rest is otherwise valid, plus someone building ZLS from scratch will probably be using a newer Zig version anyway. Once the binaries start being updated again, the version change can be revisited - what do you think?
Done. Would be nice if the repo used a config with import sorting disabled, but that currently doesn't seem to be supported with zls.json. |
It doesn't matter if the |
Alrighty. I see Andrew mentioned on Zulip that he'll update the script soonish so I hope we don't have to wait too long. |
|
Looks like this should be good to go now that the binaries are being updated again. Consequently, I've bumped the minimum version, which matches this commit. I'll let you handle the Nix stuff, along with the workflow versions. |
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/1c8ba8d3f7634acac4a2094eef7c32ad9106532c?narHash=sha256-dY9qLD0H0zOUgU3vWacPY6Qc421BeQAfm8kBuBtPVE0%3D' (2025-11-24)
→ 'github:NixOS/nixpkgs/2b0d2b456e4e8452cf1c16d00118d145f31160f9?narHash=sha256-%2B73VffE5GP5fvbib6Hs1Su6LehG%2B9UV1Kzs90T2gBLA%3D' (2025-12-17)
• Updated input 'zig-overlay':
'github:mitchellh/zig-overlay/8f7347545dea59b75e40247cc1ed55a42f64dbbf?narHash=sha256-ivb0SqCptyIxx5g8ryRrUL0xrJhLrJPlvZbZjxVaui0%3D' (2025-11-27)
→ 'github:mitchellh/zig-overlay/fe3d57ad26044f72dca171e3970fd64cc4562253?narHash=sha256-OgTpur7Iw179H0BW%2Bnmp1MsLMmz05CrmJM9ziFjEcIc%3D' (2025-12-22)
This reverts commit 433eea2.
Resolves #2525
The minimum version now corresponds to this commit - which matches what I'm currently running - but the build actually started failing since #30018. I don't use Nix so things related to that probably need to be addressed additionally.
I guess I should note that the formatter reordered the imports, but I can revert these changes if necessary...