Text format to return edited ranges instead of entire document#579
Merged
leecannon merged 4 commits intozigtools:masterfrom Aug 23, 2022
Merged
Text format to return edited ranges instead of entire document#579leecannon merged 4 commits intozigtools:masterfrom
leecannon merged 4 commits intozigtools:masterfrom
Conversation
Member
|
You are going to need to rebase on master to get the CI passing. |
Contributor
Author
|
@leecannon Done |
leecannon
approved these changes
Aug 23, 2022
Member
leecannon
left a comment
There was a problem hiding this comment.
Seems to work fine in vscode, I'm not setup for testing in any other editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the current behavior of ZLS's text formatting. Currently, ZLS will return the result of
zig fmtas the replacement text for the entire range of the document. This causes odd issues in certain text editors such as Helix which lose cursor position due to the whole document being changedThis pull request adds the ability to compare the input text and the
zig fmtoutput in order to get proper text edit ranges. I am not an expert on the LSP specification by any means, but I believe this is more in mind with how text formatting is supposed to behave. In most cases it should allow for smaller messages between the client and server as well