Workspace configuration server request model implemented!#520
Merged
SuperAuguste merged 2 commits intomasterfrom Jul 11, 2022
Merged
Workspace configuration server request model implemented!#520SuperAuguste merged 2 commits intomasterfrom
SuperAuguste merged 2 commits intomasterfrom
Conversation
Member
Author
|
Classic arbitrary test failure despite not changing any semantic tokens code... :( |
Member
Author
|
oops tests are failing because I now send string ids lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on Vesim's excellent #436 to completely implement workspace configuration! Major caveat is that this "works on my machine™️" - I've tried to make this as backwards compatible as possible (shouldn't break any zls.json-only installs, hopefully...)
I'll be opening a corresponding PR in the zls-vscode repo as some changes were needed there too; how does editor-side configuration work in other editors?