Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

fixed unneeded optional unwrap in hello_json#79

Merged
renerocksai merged 1 commit intozigzap:masterfrom
joeypas:master
Feb 23, 2024
Merged

fixed unneeded optional unwrap in hello_json#79
renerocksai merged 1 commit intozigzap:masterfrom
joeypas:master

Conversation

@joeypas
Copy link
Contributor

@joeypas joeypas commented Feb 23, 2024

hello_json example failed to compile because of optional unwrap. Fixed by removing the ".?"

@renerocksai
Copy link
Member

Thx! How the heck did that not get caught by CI...

@renerocksai renerocksai merged commit 615319a into zigzap:master Feb 23, 2024
@joeypas
Copy link
Contributor Author

joeypas commented Feb 23, 2024

I was thinking the same thing! Glad I could help

@renerocksai
Copy link
Member

It was my build_all script that did not propagate the exit code of individual failing builds. The script is completely unnecessary as it has long be replaced by zig build all. Fixed that in the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants