Ensure that accesses queue is empty when calling trackAccess
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Feb 20, 2025
|
@kyri-petrou @ghostdogpr Will you make a new release with your fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a bug to me. I think the only reason that it hasn't been reported is that it only really affects the outcome of
.sizeunder heavy contention for a very short period of time until the next time we calltrackAccess(). Still, better to fix it.Essentially we need to ensure that the queue is truly empty before we exit the
trackAccess()method, as there is a chance another thread added an item by the time we finished draining the queue and untilupdating.set(false)is called