Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert ZManaged to an abstract class to allow binary-compatible evolution #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Convert ZManaged to an abstract class to allow binary-compatible evolution #4009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions core/shared/src/main/scala/zio/ZManaged.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,18 @@ final case class Reservation[-R, +E, +A](acquire: ZIO[R, E, A], release: Exit[An
* has been consumed, the resource will not be valid anymore and may fail with
* some checked error, as per the type of the functions provided by the resource.
*/
final class ZManaged[-R, +E, +A] private (val zio: ZIO[(R, ZManaged.ReleaseMap), E, (ZManaged.Finalizer, A)])
extends Serializable { self =>
abstract class ZManaged[-R, +E, +A] extends Serializable { self =>

/**
* The ZIO value that underlies this ZManaged value. To evaluate it, a ReleaseMap is
* required. The ZIO value will return a tuple of the resource allocated by this ZManaged
* and a finalizer that will release the resource.
*
* Note that this method is a low-level interface, not intended for regular usage. As such,
* it offers no guarantees on interruption or resource safety - those are up to the caller
* to enforce!
*/
def zio: ZIO[(R, ZManaged.ReleaseMap), E, (ZManaged.Finalizer, A)]

/**
* Symbolic alias for zip.
Expand Down Expand Up @@ -1391,8 +1401,10 @@ object ZManaged extends ZManagedPlatformSpecific {
* - Returning the finalizer returned from [[ReleaseMap#add]]. This is important
* to prevent double-finalization.
*/
def apply[R, E, A](run: ZIO[(R, ReleaseMap), E, (Finalizer, A)]): ZManaged[R, E, A] =
new ZManaged(run)
def apply[R, E, A](run0: ZIO[(R, ReleaseMap), E, (Finalizer, A)]): ZManaged[R, E, A] =
new ZManaged[R, E, A] {
def zio = run0
}

/**
* Evaluate each effect in the structure from left to right, collecting the
Expand Down