Report root fibers to the supervisor #4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't you already do this with |
|
I can. But it's a different problem. Right now fibers are reported only when forked. Supervisor doesn't get notified about the root fiber. |
|
Got it! Looks great! |
adamgfraser
approved these changes
Aug 5, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR after 1.0.0 release 🦾
As the title says, adds reporting root fibers to the Supervisor. Based on a similar code in
FiberContext.forkhttps://github.com/zio/zio/blob/master/core/shared/src/main/scala/zio/internal/FiberContext.scala#L720Needed for ZIO-ZMX.