Add ZStream.onError #4097
Merged
Add ZStream.onError #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Aug 14, 2020
| } | ||
|
|
||
| /** | ||
| * Runs the specified effect if this stream fails, providing the error to the effect if it exists. |
There was a problem hiding this comment.
The corresponding method on ZIO guarantees the execution of cleanup even in the face of interruption, and also executes it uninterruptibly.
I don't think it's critical to replicate those same semantics here, but let's add a note on the scaladoc about this difference.
There was a problem hiding this comment.
Yeah I'm not sure if it's possible to provide the same semantics.
I added a note to the scaladoc.
Use case: forward a stream from storage to HTTP server, but log errors.
95aae3a to
caff4b2
Compare
iravid
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: forward a stream from storage to HTTP server, but log errors.