Fix delay computation in Schedule.fixed #4147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues:
The state maintained by
fixedkeeps the schedule's start time and the last run. The last run was wrongly initialized to the start time instead ofstart + interval. This caused a redundant immediate repetition when starting.The delay computation was wrongly computed as
(now - start) % interval. For example, givenstart = 0, now = 5000, intervalMillis = 3000, the delay would be2000instead of1000.This is fixed by computing the delay as
interval - ((now - start) % interval).Resolves #4144.