Make ZStream#aggregateAsyncWithin fail fast #4141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Aug 29, 2020
streams-tests/shared/src/test/scala/zio/stream/ZStreamSpec.scala
Outdated
Show resolved
Hide resolved
| value <- queue.takeAll | ||
| _ <- queue.shutdown | ||
| } yield assert(value)(equalTo(List(1, 2, 3, 4, 5))) | ||
| } @@ zioTag(errors), |
There was a problem hiding this comment.
Can you do a few runs with nonFlaky(50000) locally to verify the test is not flaky? Some parts of it (usage of TestClock with no advancing, use of takeAll which is not deterministic) make me a bit wary.
There was a problem hiding this comment.
I just ran it locally with nonFlaky(50000) ten times. No failures.
| sdriver <- schedule.driver.toManaged_ | ||
| lastChunk <- ZRef.makeManaged[Chunk[P]](Chunk.empty) | ||
| producer = Take.fromPull(pull).repeatWhileM(take => handoff.offer(take).as(!take.isDone)) | ||
| producer = Take.fromPull(pull).repeatWhileM(take => handoff.offer(take).as(take.isSuccess)) |
5e9236a to
7a8967d
Compare
iravid
approved these changes
Aug 29, 2020
|
@iravid ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4039