Add a promise poll to ZStream#interruptWhen #4166
Conversation
| _ <- halt.fail("Fail") | ||
| result <- ZStream(1) | ||
| .haltWhen(halt) | ||
| .interruptWhen(halt) |
|
This appears to break on Scala.js. Could you look into that? |
313dea6 to
c2dc14e
Compare
|
@iravid done, |
c2dc14e to
e77470d
Compare
| ) | ||
| as <- self.process | ||
| done <- Ref.makeManaged(false) | ||
| asPull = p.await.asSomeError *> done.set(true) *> Pull.end |
There was a problem hiding this comment.
Interesting. I compared with my suggestion here and that one got #4119 right, but would also experience #4118
There was a problem hiding this comment.
@svroonland are you sure? it checks on every pull whether the promise is done and there's a unit test for that case.
There was a problem hiding this comment.
@luis3m Ah yes on closer look, you are right. So they would appear to be equivalent then..? (just for learning purposes, you can disregard this comment thread when it comes to this PR)
There was a problem hiding this comment.
@svroonland no worries. Yes, they are.
|
Thank you @luis3m! |
Closes #4118
Closes #4119