Add some Schedule constructors for cron-like functionality #4174
Conversation
|
|
|
Yes, this is the right direction! Thanks for taking a look at these. 🙏 |
…second` param + minor fixes.
… unsafe code from minuteOfHour method.
…uteOfHour's paramter validation logic into StepFunction
There was a problem hiding this comment.
Looks great! You want to get this merged in or add the other ones following this same pattern?
Btw I didn't check the logic too closely, but I assume this recurs always on the the next specified minute boundary, e.g. if it's minute 15 and it's supposed to recur at minute 15, then that's what it does; but if it's minute 15 and it's supposed to recur on minute 16, then it will wait till that minute. Right?
…t case with nanosec
I prefer to merge this one. I'll make one more PR for the rest of the methods.
Right. Works like this:
I've just added one more test for nanosecond case, so now it ready to merge. |
…-functional fix + test
|
just one more non-functional fix. Now it's ready. |
…ondOfMinute and hourOfDay
|
since it is not merged yet, I also added |
|
@heaven-born Excellent work. Thank you for your contribution! |
* Add some Schedule constructors for cron-like functionality * doc and assertions updates * Add some Schedule constructors for cron-like functionality: bugfixing, better tests * Add some Schedule constructors for cron-like functionality: test simplification * Add some Schedule constructors for cron-like functionality: formatting/refactoring * Add some Schedule constructors for cron-like functionality: assert text fix * Add some Schedule constructors for cron-like functionality: removed `second` param + minor fixes. * Add some Schedule constructors for cron-like functionality: extracted unsafe code from minuteOfHour method. * Add some Schedule constructors for cron-like functionality: scaladoc fix * Add some Schedule constructors for cron-like functionality: removed Minute class * Add some Schedule constructors for cron-like functionality: refactoring * Add some Schedule constructors for cron-like functionality: moved minuteOfHour's paramter validation logic into StepFunction * Add some Schedule constructors for cron-like functionality: simplified test * Add some Schedule constructors for cron-like functionality: better test * Add some Schedule constructors for cron-like functionality: added test case with nanosec * Add some Schedule constructors for cron-like functionality: minor non-functional fix + test * Add some Schedule constructors for cron-like functionality: added secondOfMinute and hourOfDay
minuteOfHour,secondOfMinuteandhourOfDayfrom #4043