Enable effectual filtering of Sets #4188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mario Galic <[email protected]>
|
|
|
Tests are failing for reasons unrelated to this PR. |
adamgfraser
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #4037 to enable effectual filter of Sets as well as other Collections.
After the introduction of #4037 any pre-existing client code that used a Set as an argument to
filterhad to be converted to use a covariant collection type instead. Here is an example. Now client code need not distinguish between Sets and any other type of Collection.The reason Sets have to be treated differently has been discussed in the implementation of
foreachhere.Co-authored-by: @mario-galic