Thanks to visit codestin.com
Credit goes to github.com

Skip to content

@accessible accessors for ZStream/ZSink (#4223) #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2020
Merged

@accessible accessors for ZStream/ZSink (#4223) #4224

merged 2 commits into from
Oct 7, 2020

Conversation

@dpovey
Copy link
Contributor

@dpovey dpovey commented Sep 21, 2020 •
edited
Loading

  • Generated Stream accessors use ZStream.accessStream rather than wrapping the stream in a ZIO using ZIO.access
  • Added ZSink.provide and ZSink.accessSink
  • Generated Sink accessors use ZSink.accessSink rather than wrapping the stream in a ZIO using ZIO.access

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dpovey dpovey requested a review from iravid as a code owner September 22, 2020 14:47
@dpovey dpovey force-pushed the master branch 2 times, most recently from 51deeeb to 3c8a737 Compare September 22, 2020 15:05
@dpovey dpovey changed the title @accessible should generate accessors for ZStream (#4223) @accessible accessors for ZStream/ZSink (#4223) Sep 22, 2020
@adamgfraser
Copy link
Contributor

@dpovey Thanks for working on this. Can you resolve conflicts?

@ioleo Can you review this?

@adamgfraser adamgfraser requested a review from ioleo September 24, 2020 00:19
@dpovey
Copy link
Contributor Author

dpovey commented Sep 24, 2020

Thanks @adamgfraser. Rebased and conflicts resolved.

@dpovey dpovey force-pushed the master branch 2 times, most recently from 97cb154 to 6319c64 Compare September 30, 2020 00:41
@timaliberdov timaliberdov mentioned this pull request Oct 1, 2020
Merged
adamgfraser
adamgfraser approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this!

@adamgfraser adamgfraser merged commit 3d02996 into zio:master Oct 7, 2020
@adamgfraser adamgfraser mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid Awaiting requested review from iravid

@ioleo ioleo Awaiting requested review from ioleo

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpovey @CLAassistant @adamgfraser