Avoid Recomputing Hash Code In ZLayer #4258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
approved these changes
Sep 29, 2020
iravid
approved these changes
Sep 29, 2020
dkarlinsky
added a commit
to dkarlinsky/zio
that referenced
this pull request
Oct 30, 2021
* FiberRef.locally doesn't reset to initial value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4126.
When constructing extremely large layers performance can be negatively impacted because layers are used as keys in the
MemoMapand the hash codes of layers are recomputed each time, which can require having to recursively compute the hash codes of all layers composed into the layer. With this PR we store the hash code of a layer once it has been computed to avoid this, resulting in dramatic improvements in time to construct complex layers (from ~3seconds to ~200ms for me locally using the example from the original issue).