Don't Leak Fibers From Within ZIO#foreachParN #4253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing a dramatic improvement to stability of CI with this change. |
|
Wow 🤩 👏 |
ghostdogpr
previously approved these changes
Sep 28, 2020
|
|
||
| def worker(q: Queue[(Promise[E, B], A)], pairs: Iterable[(Promise[E, B], A)], ref: Ref[Int]): URIO[R, Unit] = | ||
| ref.getAndUpdate(_ - 1).flatMap { remaining => | ||
| if (remaining >= 0) |
There was a problem hiding this comment.
Minor: you could use ZIO.when
There was a problem hiding this comment.
Good idea! Updated now.
ghostdogpr
approved these changes
Sep 28, 2020
|
These are splendid news 🎆 |
|
@sideeffffect Yes I think we should definitely do another release very shortly. Ideally would like to get some version of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation calls
foreveron the worker fibers. IfforeachParNis called in an uninterruptible region this can result in creating fibers that continue forever and are not interruptible, potentially causing nontermination in higher levels of the application if the application waits for the interruption of these fibers through auto supervision. This is particularly problematic becauseforeachParNis called in an uninterruptible region in the release action ofZManagedwhen the execution strategy isParallelN, which is the default in ZIO Test.