Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sideeffffect
Copy link
Member

No description provided.

@sideeffffect
Copy link
Member Author

One flaky build that needs restarting, otherwise good 👍

@sideeffffect
Copy link
Member Author

@adamgfraser @mijicd could I humbly ask one of you guys to restart that one red build, please? 🙇

@mijicd
Copy link
Member

mijicd commented Sep 29, 2020

@sideeffffect done :)

@adamgfraser
Copy link
Contributor

@sideeffffect What was the failure you saw and had you merged upstream changes? Want to make sure we are more on top of flagging these build failures as they occur and addressing the underlying causes so we don't get back in the situation of having flakiness in the build.

@sideeffffect
Copy link
Member Author

It was a timeout this time.
Don't worry, no logtrace is lost!
https://app.circleci.com/pipelines/github/zio/zio/9096/workflows/31bf0ebe-a9db-4cea-af57-11138190c6db/jobs/92716

Ha! I branched off of Update izumi-reflect to 1.0.0-M8 (#4254) 93527f2f. I didn't have harden TestClock (#4248) 1774c8e3 🤔 But shouldn't CircleCI test against the PR merge branch anyway?

@adamgfraser
Copy link
Contributor

@sideeffffect I'm pretty sure it doesn't do that.

@sideeffffect
Copy link
Member Author

sideeffffect commented Sep 29, 2020

@adamgfraser 😞 you're right
It uses refs/pull/4260/head, but we need it to use refs/pull/4260/merge 🤔

@adamgfraser adamgfraser merged commit fb2adf2 into zio:master Sep 29, 2020
@sideeffffect sideeffffect deleted the zio-test-native branch September 29, 2020 21:27
@sideeffffect
Copy link
Member Author

this PR deserves the scala-native badge
@adamgfraser 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants