Handle Heterogeneous Collections in ChunkBuilder #4295
Conversation
| assertCompletes | ||
| }, | ||
| testM("chunks can be constructed from heterogeneous collections") { | ||
| check(Gen.listOf(Gen.oneOf(Gen.anyInt, Gen.anyString))) { as => |
There was a problem hiding this comment.
Would it make sense to add a generator for non-primitive types?
There was a problem hiding this comment.
Isn't String non-primitive in the sense that it is a subtype fo AnyRef as opposed to AnyVal? Or were you thinking of something different?
There was a problem hiding this comment.
The bug we're fixing here existed because heterogeneous collections were not handled correctly. It's an implementation detail that this only happened in the presence of AnyVals, because there are no optimised implementations for AnyRefs. In the future we might for example introduce a Chunk optimised for Strings. Then we could run into the same type of bug again. I was thinking of generating Options, or case classes sharing trait.
There was a problem hiding this comment.
Sounds good. Will add.
| try { | ||
| arrayBuilder += a | ||
| } catch { | ||
| case _: ClassCastException => |
There was a problem hiding this comment.
Probably the fastest way to handle this!
|
Love it! ❤️ The exception won't be thrown in the happy path, which will run at the same speed as before. 👍 |
| }, | ||
| testM("chunks can be constructed from heterogeneous collections") { | ||
| check(Gen.listOf(Gen.oneOf(Gen.anyInt, Gen.anyString, Gen.none))) { as => | ||
| assert(Chunk.fromIterable(as).toList)(equalTo(as)) |
Resolves #4288.