Implement ZIO#schedule #4296
Merged
Implement ZIO#schedule #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Oct 8, 2020
| /** | ||
| * Runs this effect according to the specified schedule. | ||
| */ | ||
| final def schedule[R1 <: R, B](schedule: Schedule[R1, Any, B]): ZIO[R1 with Clock, E, B] = |
There was a problem hiding this comment.
How about this:
scheduleWith(a)(schedule)Then:
def schedule(s) = scheduleWith(())(s)
jdegoes
previously approved these changes
Oct 8, 2020
|
Sounds good to me! |
jdegoes
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4218.
The main problem with this is that since we have to run the schedule before the effect we don't have an
Avalue to provide to theScheduleinitially so we need aSchedulewith an input type ofAny, which works for time based recurrence but doesn't allow the schedule to continue to depend on the prior result of running the effect. Potentially we could have a variant that accepts an initialAvalue to kick off the schedule though that is not ideal because we would like the schedule to completely describe the pattern of recurrence.