Add accessibleM and accessibleMM macro annotations to support HKT #4332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82fb2f2 to
664909e
Compare
664909e to
7b3beed
Compare
neko-kai
previously approved these changes
Oct 27, 2020
| private val typeParamToInject = { | ||
| val candidates = | ||
| moduleInfo.serviceTypeParams.filter { tp => | ||
| tp.tparams.forall(_.name == `_`) && tp.tparams.size == expectedTypeParams |
There was a problem hiding this comment.
tp.tparams.forall(_.name ==
_)
That's an odd check. It's legal to name type parameters in Scala, as in trait Service[F[e, a]]
There was a problem hiding this comment.
Yeah, it was really too strict a requirement. Fixed.
| """ | ||
| @accessibleMM[RIO] | ||
| object Module { | ||
| trait Service[-A, F[_, _]] { |
There was a problem hiding this comment.
It would be good to add tests also for variance annotations inside the F parameter as in:
trait Service[F[+_, _]] // should work and variance should be preserved in output code (e.g. Service[UIO] <: Service[Task])
trait Service[F[_, +_]] // should work and variance should be preserved in output code (e.g. Service[UIO] <: Service[Task])
trait Service[F[+_, +_]] // should work and variance should be preserved in output code (e.g. Service[UIO] <: Service[Task])
trait Service[F[-_, _]] // should fail because IO is not contravariant
trait Service[F[_, -_]] // should fail because IO is not contravariantThere was a problem hiding this comment.
I've added 4 more test at the end of AccessibleMMSpec and AccessibleMSpec. They don't cover all cases due to limitations of typechecking in tests, but I hope this is better than nothing.
Thank you for your help!
042718f to
1d70037
Compare
1d70037 to
1a9c0c6
Compare
|
I had to push a small fix, as I remembered that ZIO streams are not included in ZIO. |
33f7edf to
74a0599
Compare
74a0599 to
f2a7a9e
Compare
neko-kai
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3971
The purpose of this PR is to add
@accessibleMmacro that will support HKT and should work as followsSame for the
@accessibleMMmacroBoth
@accessibleMand@accessibleMMsupport polymorphic functions and traits as good as existing@accessibledoes.For simplicity, for now it is only possible to use type aliases defined in ZIO (i.e. you can't use custom type alias nor type lambda).