Delete redundant eqlReflexive instance #4350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! At this point I think we can just delete that instance since we aren't guaranteeing binary compatibility on ZIO Test, no one should be referring to the instance directly anyway, and it doesn't have an impact on the ability to make assertions. |
|
Sure, I didn't know that about ZIO Test 👍 |
Both `eqlSubtype1` and `eqlSubtype2` cover it so we prioritize them. Works around Intellij ambiguity issue.
32bf9e7 to
41de006
Compare
adamgfraser
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around Intellij ambiguity issue.
Fixes #4321