ZStream#retry (with tests this time) #4409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Nov 16, 2020
|
I figured that 'retry immediately' would make sense as a default semantic for stream retrial. Not particularly attached to it though. |
|
Ok. I tend to agree but the need for consistency with ZIO#retry ranks higher. So i would suggest that we drop the default argument. |
atooni
pushed a commit
to blended-zio/zio
that referenced
this pull request
Dec 1, 2020
* Add ZStream.retry * Implementation using ZManaged.switchable * Simplify & fix * Upgrade to 1.0.0 * Default argument for schedule * Tests for ZStream#retry * Drop default parameter Co-authored-by: Steven Vroonland <[email protected]>
This was referenced Jan 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3785, followup of #3902