Prevent Fibers From Being Terminated Prematurely In ZIO#foreachPar #4403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently code like this will not work:
The issue is that
foreachParforks a fiber to perform each of the effects and under the supervision model when that fiber terminates it terminates the fibers in its scope, including the fiber that is updating theRefin this case.The fix is to use the
transplantoperator similar to how we did withzipWithParto make sure that when fibers are forked within one of the effects inforeachParthey are forked on the original scope and not the scope of the fiber internally created byforeachPar. Conceptually this is the same issue as withzipWithPar, it looks like we just didn't push the change through toforeachPar.