Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue/4347 ignored tests not visible in report #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 24, 2020
Merged

Issue/4347 ignored tests not visible in report #4429

merged 8 commits into from
Nov 24, 2020

Conversation

@lmserrano
Copy link
Contributor

@lmserrano lmserrano commented Nov 21, 2020 •
edited
Loading

  • Add ignored suites to the list of suite presented in the test reports, with - and in yellow color.
  • Add ignored tests to the list of tests presented in the test reports, with - and in yellow color.
  • Suites which executed only contain the ignored count for the suites which were not ignored (since ignored suites are not executed and they could eventually have nested suites with more tests).
  • The ignored tests were left with the - ignored: 1 line in order to facilitate non-color-based distinction, since errors are presented also with -, and a fully colorblind person would be unable to distinguish between both without the textual hint.
  • The ignored suites now have - ignored suite to also explicitly mark them as completely ignored on top of the yellow color.
  • Closes Ignored tests not visible in report #4347

Example image attached below:

2020-11-21_22-57-47

The Spec used to produce this result was:

object MyZIOSpec extends DefaultRunnableSpec {
  def spec = suite("4 Suites")(
    suite1,
    suite2,
    suite3,
    suite4
  )

  def suite1 = suite("Suite 1 with 3 tests")(
    test("2 and 2 are the same number")(assert(2)(equalTo(2))),
    test("3 and 3 are the same number")(assert(3)(equalTo(3))),
    test("4 and 4 are the same number")(assert(4)(equalTo(4)))
  )

  def suite2 = suite("Suite 2 with 5 tests - 1 success, 1 failure and 3 ignore")(
    test("2 and 2 are the same number")(assert(2)(equalTo(2))),
    test("4 and 4 are the same number")(assert(4)(equalTo(4))) @@ TestAspect.ignore,
    test("3 and 4 are the same number")(assert(3)(equalTo(4))), // Fails
    test("5 and 5 are the same number")(assert(5)(equalTo(5))) @@ TestAspect.ignore,
    test("6 and 5 are the same number")(assert(6)(equalTo(5))) @@ TestAspect.ignore
  )

  def suite3 = suite("Suite 3 with 3 tests which will be ignored")(
    test("2 and 2 are the same number")(assert(2)(equalTo(2))),
    test("3 and 3 are the same number")(assert(3)(equalTo(3))),
    test("4 and 4 are the same number")(assert(4)(equalTo(4)))
  ) @@ TestAspect.ignore

  def suite4 = suite("Suite 4 not ignored but with 4 ignored tests")(
    test("4 and 4 are the same number")(assert(4)(equalTo(4))) @@ TestAspect.ignore,
    test("3 and 4 are the same number")(assert(3)(equalTo(4))) @@ TestAspect.ignore,
    test("5 and 5 are the same number")(assert(5)(equalTo(5))) @@ TestAspect.ignore,
    test("6 and 5 are the same number")(assert(6)(equalTo(5))) @@ TestAspect.ignore
  )
}

adamgfraser
adamgfraser approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple change! Thank you for you work on this!

@adamgfraser adamgfraser merged commit 0661677 into zio:master Nov 24, 2020
atooni pushed a commit to blended-zio/zio that referenced this pull request Dec 1, 2020
@lmserrano @atooni
Issue/4347 ignored tests not visible in report (zio#4429)
787194b 
* Add ignored Suites and Tests to the rendered test reports

* Hide the "ignored: 1" rendered in test reports for tests which are ignored within a suite

* Revert "Hide the "ignored: 1" rendered in test reports for tests which are ignored within a suite"

This reverts commit d0b6eec.

* Add explicit textual marking for ignored suites

* Fix unit tests

* Fix testRunnerJVM tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignored tests not visible in report

2 participants

@lmserrano @adamgfraser